fix(@angular/cli): ignore system files in assets - #8549
Merged
Conversation
Replaces angular/devkit#263 When copying the assets during build, the CLI must not include system files (e.g. `.DS_Store` and `Thumbs.db`). It is very important for service worker to work : if presents, these files will be included in the service worker manifest as files to cache. But such files may (and should) not be deployed to the server. Then on the client, files will be missing, then the service worker installation will fail and so all the offline feature won't work.
filipesilva
approved these changes
Nov 20, 2017
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
LGTM, @alxhub can you take a look as well please?
Member
|
@filipesilva LGTM but this is legacy SW code anyway, and doesn't affect the 5.0.0 worker. |
alxhub
self-requested a review
November 20, 2017 18:16
alxhub
approved these changes
Nov 20, 2017
Contributor
Author
|
@alxhub Why is this legacy ? Is the test already done in |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces angular/devkit#263
When copying the assets during build, the CLI must not include system files (e.g.
.DS_StoreandThumbs.db).It is very important for service worker to work : if presents, these files will be included in the service worker manifest as files to cache (according to this schematic). But such files may (and should) not be deployed to the server. Then on the client, files will be missing, then the service worker installation will fail and so all the offline feature won't work.
@hansl @filipesilva @Brocco @alxhub